-
Notifications
You must be signed in to change notification settings - Fork 9
Scheduling jar upload #1444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Scheduling jar upload #1444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abc494e
to
4acea83
Compare
47cc3cf
to
513e98d
Compare
4acea83
to
0caaf5b
Compare
513e98d
to
e9b41dc
Compare
0caaf5b
to
0459a67
Compare
74cd3fa
to
b93ad1d
Compare
c81fb06
to
6d8d031
Compare
dandelany
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 🎉 I've reviewed the code & tested locally thoroughly with a few procedural JARs. Ready to merge after backend.
6d8d031
to
eeab686
Compare
eeab686
to
a9cbeb2
Compare
Make sure we're testing against the |
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* add form element to specify file upload for scheduling goals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1436
To test:
/e2e-tests/data/example-procedure.jar